Plot editor tab sizing policies #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define metadata per client instance Filter plots from action that don't support sizing
|
E2E Tests 🚀 |
|
The unit test needs a rewrite to check that a plot client sends an event for sizing policy changes. I also think the plots service doesn't need to the event anymore. |
Fix unit test
jmcphers
approved these changes
Jan 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Addresses #5522 and #4358
Each plot client has their own metadata that now includes the sizing policy. Each plot can, whether it is in an editor tab or the view, independently set a sizing policy that will be restored on reload.
Adds an action that can switch between sizing policies for the selected plot. The action only shows the options that would be available from the sizing policy menu button in the Plots view. A custom sizing policy can only be set if there already is one set in the Plots view. It cannot be altered from the action.
Restored editors might not restore to the same editor group if there are multiple. I can follow up with adding that to the plot metadata so it can be restored to the same location. The editor order may also not be the same but I think we can live with that.
Finally, it also needs another update later to add the action to the editor toolbar but that will need more work to allow a menu style button.
Screen.Recording.2025-01-17.at.4.27.23.PM.mov
New Features
Change Plot Sizing PolicyBug Fixes
QA Notes
This is still hidden behind an experimental setting.